-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
replace JSON HHAST support with LSP support #22
Comments
I'm thinking this could be enabled by default (with an opt-out config) if |
My concern is that |
Is it possible to pop up a dialog confirming whenever a project is opened with vendor/bin/hhast-lint? If so, that would be my preference - with it remembering per-$ROOT |
Yeah, that will work. If the config isn't set, the extension can show a pop-up with yes/no options, and that value can get saved. |
just checking: that configuration can be stored outside the project root, right? I.e. I can't make a malicious project bypass the prompt by also commiting a vscode config to my project? |
Got a complete change ready for this, just waiting for FB process to say I can send a PR (FB: T31296958 P59796946) |
PR #25 |
Should:
$ROOT/vendor/bin/hhast-lint
is present (or fail gracefully if it isn't)hhast-lint --mode lsp --from vscode
Additionally, --json isn't going to be in a release
The text was updated successfully, but these errors were encountered: