Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replace JSON HHAST support with LSP support #22

Closed
fredemmott opened this issue Jun 19, 2018 · 7 comments
Closed

replace JSON HHAST support with LSP support #22

fredemmott opened this issue Jun 19, 2018 · 7 comments

Comments

@fredemmott
Copy link
Contributor

Should:

  • only run if $ROOT/vendor/bin/hhast-lint is present (or fail gracefully if it isn't)
  • be opt-in: this means that opening an editor is going to execute project-supplied code, and opening the editor should be safe
  • run hhast-lint --mode lsp --from vscode

Additionally, --json isn't going to be in a release

@PranayAgarwal
Copy link
Member

I'm thinking this could be enabled by default (with an opt-out config) if $ROOT/vendor/bin/hhast-lint is present in the workspace. Thoughts?

@fredemmott
Copy link
Contributor Author

My concern is that vscode $(pwd) then executes arbitrary code

@fredemmott
Copy link
Contributor Author

Is it possible to pop up a dialog confirming whenever a project is opened with vendor/bin/hhast-lint? If so, that would be my preference - with it remembering per-$ROOT

@PranayAgarwal
Copy link
Member

Yeah, that will work. If the config isn't set, the extension can show a pop-up with yes/no options, and that value can get saved.

@fredemmott
Copy link
Contributor Author

just checking: that configuration can be stored outside the project root, right?

I.e. I can't make a malicious project bypass the prompt by also commiting a vscode config to my project?

@fredemmott
Copy link
Contributor Author

Got a complete change ready for this, just waiting for FB process to say I can send a PR (FB: T31296958 P59796946)

@fredemmott
Copy link
Contributor Author

PR #25

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants