Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot change default font at runtime #33

Closed
gdinit opened this issue Feb 15, 2019 · 3 comments
Closed

Cannot change default font at runtime #33

gdinit opened this issue Feb 15, 2019 · 3 comments

Comments

@gdinit
Copy link

gdinit commented Feb 15, 2019

I recently found about Love2D, Lua, and this library and quite happy to play with my small app these days and tonight I wanted to add UpArrow/DownArrow = change font size functionality.

I quickly discovered, this binding does not have ImFont, ImAtlas etc. which in turn means there is no way to easily add and use new fonts (unless I'm mistaken somehow?).
After much googling I just added it myself, it's hacky but seems to work.
Sharing in a pull request, in case someone else finds this useful.

There is a gist pseudo code in the pull request.

@gdinit
Copy link
Author

gdinit commented Feb 15, 2019

Pull Request added: #32

@gdinit gdinit changed the title Can't change default font at runtime Cannot change default font at runtime Feb 15, 2019
@gdinit
Copy link
Author

gdinit commented Feb 18, 2019

I closed my PR referenced above as slages (owner) advised he is not interested in hacking embedded imgui.

However I shall leave this issue open, as it still is true and I believe it is an issue albeit a feature request.

@gdinit
Copy link
Author

gdinit commented Nov 10, 2019

Looks like this has been merged back in March (sorry, didn't check back since).
Closing the issue.

Thank you for the contribution & the merge!

@gdinit gdinit closed this as completed Nov 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant