Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

'in' can't be used as an identifier because it's a keyword. #32

Closed
ffshy1214 opened this issue Jul 28, 2021 · 4 comments
Closed

'in' can't be used as an identifier because it's a keyword. #32

ffshy1214 opened this issue Jul 28, 2021 · 4 comments
Labels
bug Something isn't working

Comments

@ffshy1214
Copy link

iso 3166 country code of India have problem, as below:

Screen Shot 2021-07-28 at 9 39 51 AM
@Tienisto Tienisto added the bug Something isn't working label Jul 28, 2021
@Tienisto
Copy link
Member

Tienisto commented Jul 28, 2021 •
edited

Thanks for this issue. I will probably add a rename from in to india

@Tienisto
Copy link
Member

Tienisto commented Jul 28, 2021 •
edited

By the way, it is more common to use language codes. Or language code + country code. Using country code only is pretty rare.
Also be aware that country codes must be in uppercase, e.g. CN not cn. Otherwise it is interpreted as language code like zh of zh-Hant-TW

@Tienisto
Copy link
Member

Fixed in 5.0.3.

@ffshy1214
Copy link
Author

By the way, it is more common to use language codes. Or language code + country code. Using country code only is pretty rare.
Also be aware that country codes must be in uppercase, e.g. CN not cn. Otherwise it is interpreted as language code like zh of zh-Hant-TW

Thanks a lot for the quick response, and We'll consider your suggestion. Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ffshy1214 @Tienisto