-
Notifications
You must be signed in to change notification settings - Fork 71
Make Empty fileds as red border after clicking add button #104
Make Empty fileds as red border after clicking add button #104
Conversation
There are conflicts! Please resolve the conflicts |
Is it possible to show the errors when the user presses the add button but before hitting the API? can you make that change? |
|
No! I mean't displaying the empty field as red only after pressing add button and not before that. By default it should be default input css style. |
@paraswaykole did you watch my video from conversation section? When I am pressing add button then only red borders are getting visible. Right? |
Ok! The video doesn't play. I will test it and merge it then. |
Looks good! One last change. backend only throws |
@paraswaykole at the place of cannot be empty? |
@paraswaykole at the place of cannot be empty? |
Nope. For showing the red input boxes |
@paraswaykole where do i have to add? |
You have already added the red border on the input boxes for all the input boxes when it throws error. Show the red border only on the 4 mentioned input boxes, remove the code for rest of them. Please make these changes. four input boxes where red border should show when it throws errors are:
|
@paraswaykole what about checkboxes red border? |
Not needed! |
@paraswaykole done |
@paraswaykole please add me as a member of your organization. I wanna contribute more in tte future. |
Don't close the PR. Ask me once for changes.
@tarunsamanta2k20
video link:
Screencast.2023-03-25.21.17.00.mp4
Issue link: #96
Issue Description:
One minor issue I found while adding a new database connection is, If any field is kept empty, it does show "cannot be empty," which is good.
We can make the border of the empty field Red if it is empty. (Warning)