Skip to content
This repository has been archived by the owner on Apr 28, 2024. It is now read-only.

Make Empty fileds as red border after clicking add button #104

Merged
merged 4 commits into from
Apr 1, 2023

Conversation

SamantaTarun
Copy link
Contributor

@SamantaTarun SamantaTarun commented Mar 25, 2023

Don't close the PR. Ask me once for changes.

@tarunsamanta2k20

video link:

image

Screencast.2023-03-25.21.17.00.mp4

Issue link: #96
Issue Description:
One minor issue I found while adding a new database connection is, If any field is kept empty, it does show "cannot be empty," which is good.
We can make the border of the empty field Red if it is empty. (Warning)

@paraswaykole paraswaykole changed the base branch from main to develop March 25, 2023 15:43
@paraswaykole
Copy link
Owner

There are conflicts! Please resolve the conflicts

@paraswaykole
Copy link
Owner

Is it possible to show the errors when the user presses the add button but before hitting the API? can you make that change?

@SamantaTarun
Copy link
Contributor Author

SamantaTarun commented Mar 29, 2023

Is it possible to show the errors when the user presses the add button but before hitting the API? can you make that change?
@paraswaykole
It's already showing beside the add button like can't be empty.

@paraswaykole
Copy link
Owner

No! I mean't displaying the empty field as red only after pressing add button and not before that. By default it should be default input css style.

@SamantaTarun
Copy link
Contributor Author

SamantaTarun commented Mar 29, 2023

@paraswaykole did you watch my video from conversation section?

When I am pressing add button then only red borders are getting visible. Right?

@SamantaTarun SamantaTarun changed the title commit_for_testing Make Empty fileds as red border after clicking add button Mar 29, 2023
@paraswaykole
Copy link
Owner

Ok! The video doesn't play. I will test it and merge it then.

@paraswaykole
Copy link
Owner

paraswaykole commented Mar 30, 2023

Looks good! One last change. backend only throws cannot be empty error when "display name or host or port or database name" is empty. Can you add these checks only for these 4 fields now?

@SamantaTarun
Copy link
Contributor Author

@paraswaykole at the place of cannot be empty?

@SamantaTarun
Copy link
Contributor Author

Looks good! One last change. backend only throws cannot be empty error when "display name or host or port or database name" is empty. Can you add these checks only for these 4 fields now?

@paraswaykole at the place of cannot be empty?

@paraswaykole
Copy link
Owner

Nope. For showing the red input boxes

@SamantaTarun
Copy link
Contributor Author

Nope. For showing the red input boxes

@paraswaykole where do i have to add?

@paraswaykole
Copy link
Owner

You have already added the red border on the input boxes for all the input boxes when it throws error. Show the red border only on the 4 mentioned input boxes, remove the code for rest of them. Please make these changes.

four input boxes where red border should show when it throws errors are:

  • display name
  • host
  • port
  • database name

@SamantaTarun
Copy link
Contributor Author

You have already added the red border on the input boxes for all the input boxes when it throws error. Show the red border only on the 4 mentioned input boxes, remove the code for rest of them. Please make these changes.

four input boxes where red border should show when it throws errors are:

  • display name
  • host
  • port
  • database name

@paraswaykole what about checkboxes red border?

@paraswaykole
Copy link
Owner

You have already added the red border on the input boxes for all the input boxes when it throws error. Show the red border only on the 4 mentioned input boxes, remove the code for rest of them. Please make these changes.
four input boxes where red border should show when it throws errors are:

  • display name
  • host
  • port
  • database name

@paraswaykole what about checkboxes red border?

Not needed!

@SamantaTarun
Copy link
Contributor Author

image

@SamantaTarun
Copy link
Contributor Author

@paraswaykole done

@paraswaykole paraswaykole merged commit b500b8d into paraswaykole:develop Apr 1, 2023
@SamantaTarun
Copy link
Contributor Author

@paraswaykole please add me as a member of your organization. I wanna contribute more in tte future.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants