Skip to content
This repository has been archived by the owner on Apr 28, 2024. It is now read-only.

Update README.md #108

Merged
merged 1 commit into from
Apr 8, 2023
Merged

Update README.md #108

merged 1 commit into from
Apr 8, 2023

Conversation

Daeraxa
Copy link
Contributor

@Daeraxa Daeraxa commented Apr 7, 2023

Following the instructions verbatim leads you to the below error. This just updates the wording to include the copying of the development file - the words are just taken from the same step in CONTRIBUTING.md. It also just corrects the heading to be the same format as the binary one.

# Building target: linux/amd64

  • Generating bindings:   ERROR   
          2023/04/08 00:15:46 Error loading development.env file
          
          exit status 1

  ERROR   
          2023/04/08 00:15:46 Error loading development.env file
          
          exit status 1

@paraswaykole
Copy link
Owner

Is this while doing make build to build production app or to setup development environment?

@Daeraxa
Copy link
Contributor Author

Daeraxa commented Apr 8, 2023

Yes, this was when doing make build to just create binaries, literally just following the instructions as they were printed. Although it seems the setup is basically the same as I was able to wails dev and that also worked (but I only found that part of the docs afterwards).

@paraswaykole
Copy link
Owner

paraswaykole commented Apr 8, 2023

Oh! Got it. Readme needs be updated to add the env file message. This is included in the PR.
Thanks for the PR. 🙌

@paraswaykole paraswaykole merged commit e902d1e into paraswaykole:main Apr 8, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants