Skip to content
This repository has been archived by the owner on Apr 28, 2024. It is now read-only.

refactor: jsontable, showdata, sidebar and global.css #114

Merged
merged 2 commits into from
Apr 16, 2023

Conversation

nc1337
Copy link
Contributor

@nc1337 nc1337 commented Apr 15, 2023

Related to issue #110

  • For fixing the issue with useTable hook, i have refered to React Table Typescript Readme
  • In remaining tsx files, i have just changed the let variable to const when it's not being changed.
  • In global.css file, as the display:flex is already added in the style, thus removed the redundant display: inline-flex.
  • Also testing the basic scenarios by running the app usnig wails dev and checking in the linux gui.

Currenlty, the way types of Row and Column are defined using any, it's
not possible to get the `useTable` hook work without error.
@paraswaykole paraswaykole changed the base branch from main to develop April 16, 2023 06:08
@paraswaykole paraswaykole merged commit 4d05a68 into paraswaykole:develop Apr 16, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants