Skip to content
This repository has been archived by the owner on Apr 23, 2021. It is now read-only.

Logging performance considerations #38

Closed
slashmo opened this issue Jun 18, 2020 · 2 comments
Closed

Logging performance considerations #38

slashmo opened this issue Jun 18, 2020 · 2 comments
Assignees
@ktoso
Labels
enhancement New feature or request i:swift-log Relates to swift-log integration question Further information is requested

Comments

@slashmo
Copy link
Owner

slashmo commented Jun 18, 2020

Currently, the computed logger property creates String representations (String(describing: value)) of everything inside the BaggageContext, although a logging configuration may not even print out this metadata.

One possibility suggested by @ktoso is to create a custom LogHandler that allows us to use the String(describing: value) call only when needed.
@slashmo slashmo added enhancement New feature or request question Further information is requested i:swift-log Relates to swift-log integration labels Jun 18, 2020
@ktoso
Copy link
Collaborator

ktoso commented Jun 18, 2020

Yup, and we can now prove that the optimizations matter or not, using the benchmark tools merged in #39

@ktoso ktoso self-assigned this Jun 25, 2020
@ktoso ktoso mentioned this issue Jun 25, 2020
Closed
@ktoso ktoso closed this as completed Jul 22, 2020
@ktoso
Copy link
Collaborator

ktoso commented Jul 22, 2020

Working on this as part of #37

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@ktoso ktoso

Labels
enhancement New feature or request i:swift-log Relates to swift-log integration question Further information is requested
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ktoso @slashmo