Skip to content
This repository has been archived by the owner on Apr 23, 2021. It is now read-only.

Consider nicer string description of baggage context #41

Closed
ktoso opened this issue Jun 20, 2020 · 1 comment · Fixed by #49
Closed

Consider nicer string description of baggage context #41

ktoso opened this issue Jun 20, 2020 · 1 comment · Fixed by #49
Assignees
Labels
enhancement New feature or request

Comments

@ktoso
Copy link
Collaborator

ktoso commented Jun 20, 2020

Current printout just uses the default properties which is BaggageContext(_storage: [:]) which reads a bit meh, since we want to hide that _storage.

Specifically, it looks like this today:

BaggageContext(_storage: [Baggage.AnyBaggageContextKey(keyType: MyModule.MyFunKey, _name: nil): Baggage.BaggageContext.(unknown context at $10773422c).ValueContainer(value: ...)])

That's a lot of noise :)

Perhaps the default rendering should only render the keys?

@slashmo slashmo added the enhancement New feature or request label Jun 20, 2020
@slashmo slashmo self-assigned this Jun 20, 2020
@slashmo
Copy link
Owner

slashmo commented Jun 20, 2020

Agreed, that's an easy win for usability 👍

@ktoso ktoso added bug Something isn't working enhancement New feature or request and removed enhancement New feature or request bug Something isn't working labels Jun 21, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants