http.server: closing socket without sending any text would hang the h…

…ttp.server. Fixes factor#311
slavapestov · Oct 29, 2011 · b740d79 · b740d79
1 parent fd944c5
commit b740d79
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 1 deletion.
diff --git a/basis/http/http-tests.factor b/basis/http/http-tests.factor
@@ -456,3 +456,14 @@ SYMBOL: a
 [ "OK\n\n" ] [ "http://localhost/" add-addr http-get nip ] unit-test
 
 [ ] [ stop-test-httpd ] unit-test
+
+! Check that just closing the socket without sending anything works
+[ ] [
+    <dispatcher>
+        add-quit-action
+    test-httpd
+] unit-test
+
+[ ] [ "addr" get binary [ ] with-client ] unit-test
+
+[ ] [ stop-test-httpd ] unit-test
diff --git a/basis/http/server/server.factor b/basis/http/server/server.factor
@@ -37,7 +37,7 @@ IN: http.server
     dup path>> "/" head? [ "Bad request: URL" throw ] unless ; inline
 
 : read-request-line ( request -- request )
-    read-?crlf [ dup empty? ] [ drop read-?crlf ] while
+    read-?crlf [ dup "" = ] [ drop read-?crlf ] while
     parse-request-line first3
     [ >>method ] [ >url check-absolute >>url ] [ >>version ] tri* ;