Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Firefox DevTools bitmap Cozette strikethrough glyphs [Minor Bug] #52

Closed
nionios opened this issue Jun 30, 2021 · 10 comments
Closed

Firefox DevTools bitmap Cozette strikethrough glyphs [Minor Bug] #52

nionios opened this issue Jun 30, 2021 · 10 comments
Labels
bug CozetteBitmap CozetteBitmap problems help wanted I have no idea how to fix this

Comments

@nionios
Copy link

nionios commented Jun 30, 2021

Hello, I noticed a weird bug relating to the firefox developer tools.

As you can see in the following screenshot, the strikethrough seems to not use the correct glyph for strikethrough text, when using a bitmap version of Cozette.

bug-firefox

However, this is not an inherent bug of the font everywhere. For example, here is a screenshot of strikethrough text in Alacritty:

strikethrough

Note that CozetteVector on the other hand works as intended:

no-bug-firefox

Firefox Version: 88.0.1
Cozette Release (bitmap, otb files): v.1.10.1b1
CozetteVector Release: v.1.9.3-1

@slavfox slavfox added the help wanted I have no idea how to fix this label Jul 2, 2021
@slavfox
Copy link
Owner

slavfox commented Jul 2, 2021

I have a sneaking suspicion that this might be related to the STRIKEOUT_ASCENT and STRIKEOUT_DESCENT BDF properties - I'll have to play around with them to try and figure out the correct values.

@slavfox slavfox added bug CozetteBitmap CozetteBitmap problems labels Jul 2, 2021
@nyonson
Copy link

nyonson commented Jun 12, 2023

I am noticing the same behavior in neovim:

image

os: arch
cozette: 1.19.2 otb

@slavfox
Copy link
Owner

slavfox commented Jun 12, 2023

My Neovim doesn't underline anything, so I can't reproduce it on my end; Could you check if the same behavior exists between cozette.otb 1.19.2 and cozette.otb 1.19.2-hidpi (not cozette_hidpi.otb)

@nyonson
Copy link

nyonson commented Jun 12, 2023

Tested with both those versions and see the same thing. Fwiw the strikethroughs are for deprecated hints from the LSP.

@nyonson
Copy link

nyonson commented Jun 12, 2023

It appears to work with the new hidpi version (cozette_hidpi.otb v.1.19.2-hidpi2) though:

image

@slavfox
Copy link
Owner

slavfox commented Jun 12, 2023

Is it still broken with the normal-sized version of the font?

@nyonson
Copy link

nyonson commented Jun 12, 2023

That's right, normal sized still has the issue.

@slavfox
Copy link
Owner

slavfox commented Jun 12, 2023

That's... deeply unsettling, since the hidpi version is built from the same sources and literally just has the glyphs and their bounding boxes scaled up by a factor of two.

Could you try this version?
cozette_otb.zip

@nyonson
Copy link

nyonson commented Jun 12, 2023

Ah, that worked, maybe I grabbed the wrong version on my last test?

@slavfox
Copy link
Owner

slavfox commented Jun 12, 2023

No, this seems to be a problem in how FontForge generates the fonts. The GitHub release builds all formats directly from the .sfd source; the build I attached was compiled to .bdf first, and then converted to .otb. I'll release a new version in a minute.

I'm glad it works, finally! I don't know if I could've done anything to fix it if it hadn't worked this time :P

@slavfox slavfox closed this as completed Jun 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug CozetteBitmap CozetteBitmap problems help wanted I have no idea how to fix this
Projects
None yet
Development

No branches or pull requests

3 participants