Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doctor in two units: only one subpage is provided #154

Closed
lukarenko opened this issue Dec 24, 2021 · 2 comments · Fixed by #166
Closed

Doctor in two units: only one subpage is provided #154

lukarenko opened this issue Dec 24, 2021 · 2 comments · Fixed by #166
Labels
bug Something isn't working
Milestone

Comments

@lukarenko
Copy link
Contributor

lukarenko commented Dec 24, 2021

If the doctor is operating in two units, when you try to open the doctor page you get only the first data:

Example:
image

When you open it, you get:
https://zdravniki.sledilnik.org/sl/gyn/bizjak-tina

As URL is not unique (no ID of institution), we only show first.

Solution is to put ID of institiution in URL (but we would need some persitent ID like ZZZS number)

@lukarenko
Copy link
Contributor Author

id_inst key is persistent now (based on ZZZS ID) and can be used as key for unique doctor URL.

We should extend URLs in following form:
https://zdravniki.sledilnik.org/sl///<id_inst>

If <id_inst> is not specified, we should fallback to first institution (like already now).

The following URLs should work for the above example:
https://zdravniki.sledilnik.org/sl/gyn/bizjak-tina/789398
https://zdravniki.sledilnik.org/sl/gyn/bizjak-tina/91432
https://zdravniki.sledilnik.org/sl/gyn/bizjak-tina

last one is just redirect to first one.

@lukarenko
Copy link
Contributor Author

@jalezi done the first part, but not sure if we should bother about redirect as we are pre-release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants