Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Linting and prettier #7

Closed
mihaerzen opened this issue Nov 23, 2021 · 3 comments
Closed

Linting and prettier #7

mihaerzen opened this issue Nov 23, 2021 · 3 comments
Assignees

Comments

@mihaerzen
Copy link
Collaborator

Hi!

I went ahead and had a look at some of the pull requests. The first thing I noticed is there are different coding styles used between different authors. As this is an open-source project which will hopefully have many contributors I would suggest adding some linting to enforce a certain coding style. I believe this will increase readability and make pull request reviews easier.

Personally, I would vote to adopt eslint airbnb-typescript as I think it fits what I have seen in the code so far. I would also add this to the CI so it will run when pull request is created.

Let me know what you think!

Thank you for your amazing contributions so far! 👏🏼

@jalezi
Copy link
Collaborator

jalezi commented Nov 23, 2021

Thanks @mihaerzen. Add whatever you think is necessary.

@mihaerzen mihaerzen self-assigned this Nov 30, 2021
@mihaerzen
Copy link
Collaborator Author

Quick update, I am working on this I just struggled to allocate time for it.

@mihaerzen
Copy link
Collaborator Author

PR opened.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants