You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I went ahead and had a look at some of the pull requests. The first thing I noticed is there are different coding styles used between different authors. As this is an open-source project which will hopefully have many contributors I would suggest adding some linting to enforce a certain coding style. I believe this will increase readability and make pull request reviews easier.
Personally, I would vote to adopt eslint airbnb-typescript as I think it fits what I have seen in the code so far. I would also add this to the CI so it will run when pull request is created.
Let me know what you think!
Thank you for your amazing contributions so far! 👏🏼
The text was updated successfully, but these errors were encountered:
Hi!
I went ahead and had a look at some of the pull requests. The first thing I noticed is there are different coding styles used between different authors. As this is an open-source project which will hopefully have many contributors I would suggest adding some linting to enforce a certain coding style. I believe this will increase readability and make pull request reviews easier.
Personally, I would vote to adopt eslint
airbnb-typescript
as I think it fits what I have seen in the code so far. I would also add this to the CI so it will run when pull request is created.Let me know what you think!
Thank you for your amazing contributions so far! 👏🏼
The text was updated successfully, but these errors were encountered: