-
Notifications
You must be signed in to change notification settings - Fork 110
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Models should be in separate indices #34
Comments
This is exactly the problem I tried to solve with the According to this page it depends highly on your use case whether or not you should store every model in a different index or use types instead. I suggest adding something like an With the |
Yeah. I still think though, that for eloquent models in particular, each should be in it's own index by default. That could probably happen in the EloquentPersistence class and a few other places. |
Done in v0.2.5 , also added custom index for suggestion and mapping |
According to this page, one shouldn't mix different types of data in a single index. By default, Plastic stores all models in a single index, and differentiates based on type.
However, the underlying Lucene instance flattens out all mappings, causing conflict issues like #31. I have also started to run into issues like this.
Totally understanding how big a change this would be, I reckon we should think about changing this package to use separate indices for each model type by default. I'd be happy to tackle the work and open a PR.
Thoughts?
The text was updated successfully, but these errors were encountered: