Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crashes with Inspecio entity rendering. #50

Closed
LambdAurora opened this issue Jul 18, 2021 · 0 comments
Closed

Crashes with Inspecio entity rendering. #50

LambdAurora opened this issue Jul 18, 2021 · 0 comments
Labels
bug Something isn't working p:high

Comments

@LambdAurora
Copy link

We got an issue about a crash with the rendering of this mod's entities on Inspecio's tooltips: Queerbric/Inspecio#13.

From the crash report, it's because when this mod is trying to read the NBT of the Horned Sheep, it tries to cast the entity's world to ServerWorld.

The thing is, those read/write NBT methods have no guarantees on which side they will be called, and Inspecio needs to give a ClientWorld.

The weirdest is the readAngerFromNbt method takes a World as parameter and performs itself the instanceof check.
I would suggest to drop any cast and just pass this.world as-is.

@Slexom Slexom added bug Something isn't working p:high labels Aug 14, 2021
@Slexom Slexom closed this as completed in 0a00f22 Aug 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working p:high
Projects
None yet
Development

No branches or pull requests

2 participants