Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

reserved identifier violation #3

Closed
elfring opened this issue Mar 23, 2017 · 6 comments
Closed

reserved identifier violation #3

elfring opened this issue Mar 23, 2017 · 6 comments

Comments

@elfring
Copy link

elfring commented Mar 23, 2017

I would like to point out that identifiers like “_Brush” and “_Font” do not fit to the expected naming convention of the C++ language standard.
Would you like to adjust your selection for unique names?
@fred1218zh
Copy link
Member

Thanks for your suggestion.

@fred1218zh
Copy link
Member

This issue is moved to #5

fred1218zh added a commit that referenced this issue Mar 24, 2017
@fred1218zh
#4 Remove unnecessary null pointer checks
fe92599 
#3 Follow the C++ standard rules regarding reserved names
@fred1218zh
Copy link
Member

Because it is very big codebase, the reserved name issue will be fixed gradually. Instead I've opened new issue #5

@elfring
Copy link
Author

elfring commented Mar 8, 2018

There are still more update candidates to consider.

fred1218zh added a commit that referenced this issue Mar 9, 2018
@fred1218zh
#3 Fix naming issue - reserved identifier violation
86f64e1
@grossingdev
Copy link

I've pushed remaining updates.

@elfring
Copy link
Author

elfring commented Mar 9, 2018

Thanks for another source code improvement.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@elfring @fred1218zh @grossingdev