Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unnecessary null pointer checks #4

Closed
elfring opened this issue Mar 23, 2017 · 5 comments
Closed

Remove unnecessary null pointer checks #4

elfring opened this issue Mar 23, 2017 · 5 comments

Comments

@elfring
Copy link

elfring commented Mar 23, 2017

An extra null pointer check is not needed in functions like the following.
@fred1218zh
Copy link
Member

null pointer check is needed there.

@elfring
Copy link
Author

elfring commented Mar 24, 2017

Are you aware that the delete operator implementation will tolerate passed null pointers?

@fred1218zh
Copy link
Member

I've really missed that info.
This issue is already fixed.
Thanks for your advise. 👍

@elfring
Copy link
Author

elfring commented Mar 24, 2017

Which commits will contain corresponding changes?

fred1218zh added a commit that referenced this issue Mar 24, 2017
@fred1218zh
#4 Remove unnecessary null pointer checks
fe92599 
#3 Follow the C++ standard rules regarding reserved names
@fred1218zh
Copy link
Member

It is fe92599

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@elfring @fred1218zh