Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changing settings crashes the app #1764

Closed
OhmEye opened this issue Feb 11, 2014 · 9 comments
Closed

Changing settings crashes the app #1764

OhmEye opened this issue Feb 11, 2014 · 9 comments
Labels
Milestone

Comments

@OhmEye
Copy link

OhmEye commented Feb 11, 2014

With current master I can't edit print settings fields, here is a specific example:

  1. Run slic3r.
  2. Click Print Settings tab.
  3. Click Skirt and Brim.
  4. Select the contents of the Distance From Object field.
  5. Press any key (I press the 5 key to because I want 5mm distance.)

Slic3r quits with this error:

Argument "" isn't numeric in subroutine entry at /mnt/oldroot/in/slic3r/Slic3r/lib/Slic3r/GUI/OptionsGroup.pm line 392.

The loaded settings I have at the time are http://ohmeye.com/download/debug/slic3r_doublefill/config.ini

@JoeRacette
Copy link

Same problem
1.0.1 dev
Master commit 4251917
Ubuntu 32bit 13.10

@anwe79
Copy link

anwe79 commented Feb 15, 2014

What perl version do you have? I'm getting warnings about running about perl >= 5.16 not being supported/recommended, but i thought that was fixed by now (there's an old bug reffering to it).

I have the same problem as OP, but also slic3r can't read my config file. The bed size value contains a comma, which somehow also get's the verdict not being numeric. (I'm running perl 5.18 and downgrading is not an option, dependency hell lies that way.) Trying with a new config file and setting the values via GUI, slic3r writes the value with a comma, catch 22...

I think these are all related, but not sure.

PS. I'm on Debian Jessie/Sid amd64, just did a git pull. Maybe that was stupid, gonna try 1.0.0RC2 now.
PPS. Nope, same problem in RC2.

@anwe79
Copy link

anwe79 commented Feb 15, 2014

Looks like this is related to/duplicate of #1709 .

@OhmEye
Copy link
Author

OhmEye commented Feb 15, 2014

I'm running perl 5.16. I didn't see #1709, thanks. I will try that workaround the next time I test master (probably after #1758 is fixed.)

@anwe79
Copy link

anwe79 commented Feb 16, 2014

Ok, good to know it's probably not Perl 5.18 then.
#1649 Seems to be another duplicate.

I'm going to backtrack a bit and see where the problem crops up. I think i was on master a bit pre 1.0.0RC1 before i had the issue. If i have enough time, i'll try a bisect to pinpoint.

(I think my problem with a comma in the config file may be unrelated to the problem of empty fields gettting reported as non numeric. My comma issue could be locale related.
I'm using an sv-SE locale, and we use a decimal comma not decimal point. I'll muck around with the locale a bit and see if it dissapears. If it does I'll report that separately.)

@nastybyte
Copy link

Confirmed on Debian:
3.2.0-4-amd64 #1 SMP Debian 3.2.53-2 x86_64 GNU/Linux
Perl 5.14.2
Slic3r 1.0.1-dev
I also use sv-SE locale.

@anwe79
Copy link

anwe79 commented Feb 19, 2014

The comma issue is separate and locale related, see #538.
It's been open for a long while, but fortunately there's an easy workaround. Haven't had time to investigate further on the settings issue, may give it a go this weekend.

@anwe79
Copy link

anwe79 commented Feb 22, 2014

I'm giving up on bisecting for now. The older versions i tried won't work with my perl version.
(I used a different computer before, when i didn't have this problem)
Someone with a bit more insight in the code needs to step up here i think.

@alranel alranel added this to the 1.1.0 milestone Mar 23, 2014
@alranel
Copy link
Member

alranel commented Mar 24, 2014

Thank you, fixed in 7a58457

@alranel alranel closed this as completed Mar 24, 2014
@alranel alranel added the Fixed label Mar 24, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants