Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Slice state invalidation is not well-tested #4365

Open
lordofhyphens opened this issue Apr 4, 2018 · 1 comment
Open

Slice state invalidation is not well-tested #4365

lordofhyphens opened this issue Apr 4, 2018 · 1 comment
Labels
Code Cleanup/Refactoring This is a cleanup/refactor effort that should not affect functionality. good first issue help wanted

Comments

@lordofhyphens
Copy link
Member

Version

1869b06

The tests for libslic3r could use more fleshing out around the invalidation logic (changing what config options invalidates what).

The only real complexity here is that some reverse-engineering needs to be done around the invalidation of regions to properly test things like perimeters (you need to set up some model objects, etc).

Ideally, I think that every configuration option that Slic3r supports should have its behavior tested for regression purposes, but I think that testing the important representative samples will get us by for now.

Related to #4364

Refer to 7b8369d for a simple example (invalidating skirt step based on changing skirt count).

@lordofhyphens lordofhyphens added Code Cleanup/Refactoring This is a cleanup/refactor effort that should not affect functionality. good first issue help wanted labels Apr 4, 2018
@lordofhyphens
Copy link
Member Author

lordofhyphens commented Apr 4, 2018

Quickly running the tests on Windows (this assumes you can build Slic3r and have built it at least once)

  1. Open up an instance of powershell.
  2. Go to the slic3r/xs directory in powershell.
  3. Run the following (replacing /path/to with the actual path to your Slic3r checkout):
    Invoke-Expression "$(perl -Mlocal::lib=/path/to/slic3r/local-lib)"
  4. Run perl t/20_print.t to execute the single test.

For Linux or OSX (using bash):

  1. Open up an instance of a terminal.
  2. Go to the slic3r/xs directory in the terminal.
  3. Run the following (replacing /path/to with the actual path to your Slic3r checkout):
    eval "$(perl -Mlocal::lib=/path/to/slic3r/local-lib)"
  4. Run perl t/20_print.t to execute the single test.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Code Cleanup/Refactoring This is a cleanup/refactor effort that should not affect functionality. good first issue help wanted
Projects
None yet
Development

No branches or pull requests

1 participant