Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A possible solution to removing driver dependency from dialect #22

Closed
aacanakin opened this issue Mar 5, 2016 · 1 comment
Closed
Milestone

Comments

@aacanakin
Copy link
Member

Currently, almost any structs, especially dialect depends on driver string. However, it seems it doesn't have to be that way.

Query struct would keep the placeholders in named statements. Only SQL() function should have driver dependency. Moreover, SQL() function should convert the named placeholders into native placeholders.

@aacanakin aacanakin added this to the qb 0.1 milestone Mar 5, 2016
@aacanakin
Copy link
Member Author

Named placeholder would not be necessary. Just putting "?" will be enough. For postgres, SQL(driver string) function should replace the "?" into binding indexed $%d. It looks like a ugly hack but is solves the current problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant