Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scala Steward wants to update database-related dependencies #2169

Closed
SethTisue opened this issue Feb 17, 2021 · 6 comments
Closed

Scala Steward wants to update database-related dependencies #2169

SethTisue opened this issue Feb 17, 2021 · 6 comments
Assignees

Comments

@SethTisue
Copy link
Member

Over at https://github.com/slick/slick/pulls there are a bunch of Scala Steward PRs updating versions of drivers (adapters?) for postgresql and sqlite and so forth. (I already merged all the steward PRs for things like sbt plugins.)

I don't know a database from a dead badger and I don't know whether to merge these PRs. Should we just merge them and assume the likely good outweighs the possible bad? Or close them since it's possible some of the updates might somehow break something? (Or is it enough that the tests pass?)

Opinions?

@SethTisue
Copy link
Member Author

SethTisue commented Feb 17, 2021

(I suppose one possibility would to be merge them, but then bump our version number and add -RC1, too, to allow time for testing?)

@hvesalai
Copy link
Member

Well.. a dead badger, as opposed to a DB, looks like we can safely merge most of them.

@SethTisue
Copy link
Member Author

okay, one vote for merging. I guess I'll let this sit until March 1 or so and if no other opinions emerge, let's go for it.

@SethTisue
Copy link
Member Author

(but first I need to fix CI, I tried to migrate from travis-ci.org to travis-ci.com and something went wrong, I don't know what, yet)

@SethTisue
Copy link
Member Author

Travis-CI is working now.

I rebased all the steward PRs and Travis is now chewing through them one by one, which will take days: https://travis-ci.com/github/slick/slick/pull_requests . I'll merge any that pass CI.

@SethTisue SethTisue self-assigned this Mar 13, 2021
@SethTisue
Copy link
Member Author

All the PRs are merged now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants