Use Acq/Rel ordering everywhere #17
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also fix docs
yvt
reviewed
Oct 9, 2021
There was a problem hiding this comment.
Looks good, but they are unnecessarily strong in many places. They are are harmless by themselves but can conceal synchronization bugs in user code.
Another possible option is to keep the ordering parameters but enforce a minimum ordering like atomic_ref 0.2.1.
| @@ -244,7 +235,7 @@ where | |||
| P: IntoRawPtr + FromRawPtr, | |||
| { | |||
| fn drop(&mut self) { | |||
| self.take(Ordering::Relaxed); | |||
| self.take(); | |||
There was a problem hiding this comment.
This can use the Relaxed ordering or even a non-atomic access (*self.inner.get_mut())
| pub fn compare_and_swap( | ||
| &self, | ||
| current: Option<&P>, | ||
| new: Option<P>, | ||
| order: Ordering, | ||
| ) -> Result<Option<P>, (Option<P>, *mut P)> { |
There was a problem hiding this comment.
Unrelated to the change, but isn't this *mut P actually *mut <P as Deref>::Target? At least this is true for the IntoRawPtr implementations provided by this crate.
| ) -> Result<Option<P>, (Option<P>, *mut P)> { | ||
| let pnew = Self::inner_into_raw(new); | ||
| self.inner | ||
| .compare_exchange(Self::inner_as_ptr(current), pnew, success, failure) | ||
| .compare_exchange(Self::inner_as_ptr(current), pnew, Ordering::AcqRel, Ordering::Acquire) |
| ) -> Result<Option<P>, (Option<P>, *mut P)> { | ||
| let pnew = Self::inner_into_raw(new); | ||
| self.inner | ||
| .compare_exchange_weak(Self::inner_as_ptr(current), pnew, success, failure) | ||
| .compare_exchange_weak(Self::inner_as_ptr(current), pnew, Ordering::AcqRel, Ordering::Acquire) |
Apply suggestions from code review Co-authored-by: yvt <i@yvt.jp>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #15
Changed all methods to use
Acquire,ReleaseorAcqRel, whichever is the strictest.I had to remove the ordering parameters from all the methods, so it's a breaking change.