Expose the wrapped storage from Read/WriteStorage #419
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
torkleyy
approved these changes
May 19, 2018
src/storage/mod.rs
Outdated
| @@ -192,6 +192,11 @@ where | |||
| T: Component, | |||
| D: Deref<Target = MaskedStorage<T>>, | |||
| { | |||
| /// Gets the wrapped storage. | |||
| pub fn storage(&self) -> &T::Storage { | |||
There was a problem hiding this comment.
Could we name this unprotected_storage? I usually prefer short names, but in this case it's not what most people are looking to use, so I think it's good to have some kind of warning.
|
Ah please also do a bump of the patch version so I can release after it's merged. |
|
Okay, this time my review comes in three parts, I have one last request: Please add your change to the changelog. That should be it now :) |
torkleyy
approved these changes
May 19, 2018
bors bot
added a commit
that referenced
this pull request
May 19, 2018
419: Expose the wrapped storage from Read/WriteStorage r=torkleyy a=andrewhickman This is already possible through `Join::open` (although not very ergonomic), so there shouldn't be any soundness issues here. This is useful for using custom storages with additional methods. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/slide-rs/specs/419) <!-- Reviewable:end --> Co-authored-by: Andrew Hickman <andrew.hickman1@sky.com>
Build succeeded |
|
Specs 0.11.2 is uploaded now :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is already possible through
Join::open(although not very ergonomic), so there shouldn't be any soundness issues here. This is useful for using custom storages with additional methods.This change is