Added some comments to the saveload example #492
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
torkleyy
reviewed
Oct 14, 2018
examples/saveload.rs
Outdated
| @@ -9,6 +9,10 @@ use specs::error::NoError; | |||
| use specs::prelude::*; | |||
| use specs::saveload::{DeserializeComponents, MarkedBuilder, SerializeComponents, U64Marker, U64MarkerAllocator}; | |||
|
|
|||
| // This is an example of how the serialized data of two entities might look on disk. | |||
| // | |||
| // When serializing entities, they are written in an array of unnamed structs, each struct representing one entity. | |||
There was a problem hiding this comment.
unnamed structs -> tuples
That's only if you pass a tuple of component storages though. Custom structs are possible, and will be easier with the derive PR.
examples/saveload.rs
Outdated
| impl From<ron::ser::Error> for Combined { | ||
| fn from(x: ron::ser::Error) -> Self { | ||
| Combined::Ron(x) | ||
| } | ||
| } | ||
|
|
||
| // This returns nothing, in case a `NoError` is received. |
There was a problem hiding this comment.
This cannot be called, thus it cannot return.
torkleyy
approved these changes
Oct 17, 2018
torkleyy
approved these changes
Oct 17, 2018
bors bot
added a commit
that referenced
this pull request
Oct 17, 2018
492: Added some comments to the saveload example r=torkleyy a=Telzhaak I hope they are all correct, please verify. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/slide-rs/specs/492) <!-- Reviewable:end --> Co-authored-by: Telzhaak <da.ahrens@outlook.de>
|
I tried, but broke everything locally. So I decided to be save and do it here |
Build succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hope they are all correct,
please verify.
This change is