Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing require('assert') in operation builders #15

Closed
estliberitas opened this issue May 7, 2015 · 0 comments · Fixed by #16
Closed

Add missing require('assert') in operation builders #15

estliberitas opened this issue May 7, 2015 · 0 comments · Fixed by #16

Comments

@estliberitas
Copy link
Contributor

In following files var assert = require('assert'); is missing:

  • lib/builders/exists.js;
  • lib/builders/get-children.js;
  • lib/builders/get-data.js;
  • lib/builders/set-data.js;

Which can cause ReferenceError and potentially crash.

The only reason it worked in tests is that assert was defined globally in test/support/globals.js. Damn, damn me!
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix require issue
1 participant
@estliberitas