fix: Non-number slideScale causing mispositioning (#174)

slidevjs · May 25, 2021 · 596b4a7 · 596b4a7
1 parent 53ec985
commit 596b4a7
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 4 deletions.
diff --git a/packages/client/internals/Settings.vue b/packages/client/internals/Settings.vue
@@ -3,10 +3,10 @@ import { slideScale } from '../state'
 import SelectList from './SelectList.vue'
 import type { SelectionItem } from './types'
 
-const items: SelectionItem<number | null>[] = [
+const items: SelectionItem<number>[] = [
   {
     display: 'Fit',
-    value: null,
+    value: 0,
   },
   {
     display: '1:1',

diff --git a/packages/client/internals/SlideContainer.vue b/packages/client/internals/SlideContainer.vue
@@ -33,7 +33,7 @@ if (props.width) {
 const screenAspect = computed(() => width.value / height.value)
 
 const scale = computed(() => {
-  if (props.scale != null)
+  if (props.scale)
     return props.scale
   if (screenAspect.value < slideAspect)
     return width.value / slideWidth

diff --git a/packages/client/state/index.ts b/packages/client/state/index.ts
@@ -20,7 +20,7 @@ export const isOnFocus = computed(() => ['BUTTON', 'A'].includes(activeElement.v
 
 export const currentCamera = useStorage<string>('slidev-camera', 'default')
 export const currentMic = useStorage<string>('slidev-mic', 'default')
-export const slideScale = useStorage<number>('slidev-scale', null)
+export const slideScale = useStorage<number>('slidev-scale', 0)
 
 export const showEditor = useStorage('slidev-show-editor', false)
 export const editorWidth = useStorage('slidev-editor-width', isClient ? window.innerWidth * 0.4 : 100)