Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust slide height on content load #1182

Closed
aoelen opened this issue Jul 9, 2019 · 1 comment
Closed

Adjust slide height on content load #1182

aoelen opened this issue Jul 9, 2019 · 1 comment
Labels
enhancement iOCW Issue was created/worked on during iOCW project

Comments

@aoelen
Copy link
Member

aoelen commented Jul 9, 2019

When a slide contains images, the height of the slide can be set incorrectly. This because the images are loaded asynchronously. Make sure that the slide height is adjust on a full page load (temporary fix would be to make the slide content scrollable, so at least it is possible to see the slide content).

Example:

Screen Shot 2019-07-09 at 17 49 40

@bwulff bwulff added this to Triage in InclusiveOCW Aug 23, 2019
@aoelen aoelen moved this from Triage to Selected for Dev in InclusiveOCW Sep 17, 2019
@bwulff bwulff added enhancement iOCW Issue was created/worked on during iOCW project labels Sep 19, 2019
@aoelen
Copy link
Member Author

aoelen commented May 7, 2020

It seems like this is only a problem with legacy slides (not using canvas mode). So closing it,

@aoelen aoelen closed this as completed May 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement iOCW Issue was created/worked on during iOCW project
Projects
InclusiveOCW
  
Selected for Dev
Development

No branches or pull requests

2 participants