New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix matching of entities between manifest and catalog #14
Conversation
5e39902
to
9d42cce
Compare
9d42cce
to
6d6ac4a
Compare
This fixes two issues: 1. Some systems (e.g. Snowflake) uppercase all table and column names. In accordance with the dbt-docs official source code, we lowercase all table and column names before matching them. 2. There can be multiple tables with the same name but in different schemas. We therefore use schema_name.table_name to distinguish tables.
Use domain object ColumnRef for storing information about covered and not covered columns instead of raw strings which then need to be parsed.
6d6ac4a
to
5580736
Compare
@mrshu, I refactored the code, I believe it's much cleaner now. The following was done:
I believe this is a final code. Could I please bother you for one last round of review? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nicely done @sweco, let's get it in!
a60ad34
to
c0504f6
Compare
c0504f6
to
9d0be3c
Compare
This fixes two issues: