dbt 1.0 #27
Merged
dbt 1.0 #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi Andrej, Thank you for looking into this. |
|
@sweco Given the relatively fast release cycles of |
sweco
force-pushed
the
dbt-1.0
branch
2 times, most recently
from
442fc31
to
15392dc
Compare
|
Thanks @mrshu, makes sense and actually we can add the support for older dbt at any time. I added a badge as well as a small note in the beginning of the README. |
mrshu
reviewed
Apr 1, 2022
mrshu
approved these changes
Apr 1, 2022
Tests representation in the manifest.json have changed. Updating to the new format of manifest.json results in non-compatibility with dbt<1. Warn when used with unsupported manifest.json version
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@mrshu, I acknowledged the changes in the new v4
manifest.jsonformat introduced by dbt 1.0 and by that the support for v3 dropped. Since the difference between the formats is only tiny, do you think it would make sense to support also v3manifest.json(used in dbt<1) by having 2 methods for parsing the manifest, one for v3 and one for v4?Closes #26.