Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom run artifacts path #38

Merged
merged 6 commits into from Nov 15, 2022
Merged

Conversation

Fszta
Copy link
Contributor

@Fszta Fszta commented Jul 30, 2022

Goal

Give more flexibility to user who have their manifest.json & catalog.json files not stored in /target, which is mainly the case for user using dbt cloud (need to retrieve the file by api call), adding a new parameter to use a custom path allow user not to create an unnecessary targetdir in their cicd pipeline

Description

  • Add run_artifacts_dir : Path parameter to load_manifest and load_catalog
  • Add optional run_artifacts_dir parameter to cli

@mrshu
Copy link
Contributor

mrshu commented Nov 3, 2022

Hey @Fszta, thanks for adding this!

Would you happen to have a bit of time to resolve the conflict in __init__.py?

Thanks!

@mrshu mrshu self-assigned this Nov 3, 2022
@Fszta
Copy link
Contributor Author

Fszta commented Nov 3, 2022

Hi @mrshu, done :) I've slightly updated the error message to make it more consistent with both case, custom or default folder

@mrshu
Copy link
Contributor

mrshu commented Nov 10, 2022

Thanks a lot @Fszta, this looks nice!

Would you mind adding yourself to the CHANGELOG.md similarly to https://github.com/slidoapp/dbt-coverage/pull/45/files#diff-06572a96a58dc510037d5efa622f9bec8519bc1beab13c9f251e97e657a9d4edR9 ? We can then easily merge this in 🙂

Thanks again!

@mrshu
Copy link
Contributor

mrshu commented Nov 15, 2022

Sorry @Fszta, the merges from other PRs have made this such that there are again conflicts...

Would you mind resolving them one last time please?

Copy link
Contributor

@mrshu mrshu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a bunch @Fszta!

@mrshu mrshu merged commit 367a014 into slidoapp:main Nov 15, 2022
@mrshu
Copy link
Contributor

mrshu commented Nov 17, 2022

Thanks again @Fszta, this was now released in 0.3.0!

I also took the liberty of adding a bit of documentation on it in the README: https://github.com/slidoapp/dbt-coverage#custom-run-artifacts-path-with---run-artifacts-dir

Hope you like it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants