New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tabulate doc coverage output using markdown #47
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the PR @vvvito!
It looks rather nice -- I had only one suggestion about the use of Enum
-- do let me know if that would make sense to you.
Also, would you mind adding yourself to the CHANGELOG.md
just as on the link below? That would help us make sure we attribute your work correctly 🙂
Thanks!
Thanks @mrshu Also updated Changelog with attribution and resolved conflicts between other PRs |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a bunch @vvvito, just one last comment and this is good to go!
Thanks again @vvvito, this was now released in I also took the liberty of adding a short section on it to the docs: https://github.com/slidoapp/dbt-coverage#markdown-output-with---cov-format I hope you like it! |
Resolves #46
What has changed?
Introduces a new argument called
cov_format
that acceptsstring
(default) ormarkdown
for thecompute doc
command.Outputs the results to the terminal in either the default string format, or in a markdown friendly format
Example
results in: