Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up len(model_path_filter) >= 1 once a Typer issue gets resolved #48

Open
mrshu opened this issue Nov 15, 2022 · 2 comments
Open

Clean up len(model_path_filter) >= 1 once a Typer issue gets resolved #48

mrshu opened this issue Nov 15, 2022 · 2 comments
Labels
good first issue Good for newcomers

Comments

@mrshu
Copy link
Contributor

mrshu commented Nov 15, 2022

Originally I had used is not None as you say, however, this doesn't work due to a known issue with typer: tiangolo/typer#410 whereby [an] "Empty tuple [is] returned for Option instead of expected None when no values passed". As such, I have to use len() since until the issue is resolved model_path_filter will never be None.

Since you asked the question it's obvious that I could make the reason for my choice clearer, WDYT to the below suggestion?

Originally posted by @followingell in #45 (comment)
@mrshu mrshu added the good first issue Good for newcomers label Nov 15, 2022
@mrshu
Copy link
Contributor Author

mrshu commented Nov 15, 2022

@followingell please do not hesitate to suggest a better title here 🙂

@mrshu
Copy link
Contributor Author

mrshu commented Nov 15, 2022

For posterity, let us note that the Typer issue in question is tiangolo/typer#410

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@mrshu