refactor: URL params in Dashboard listing #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Refactor the way URL params are being passed to requests in Dashboard listing in `pull_dashboards.py`, as the previous version has been susceptible to encoding issues. Signed-off-by: mrshu <mrshu@cisco.com>
|
Thanks for this, @mrshu! ⭐ Shall we apply the same logic to |
…sh_descriptions.py` Refactor the way URL params are being passed to requests in Dataset listing in as the previous version has been susceptible to encoding issues.
|
@mrshu I also updated the other functions using the same logic as mentioned in the previous comment. Thank you and merging! |
This was referenced Mar 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pull_dashboards.py, as the previous version has been susceptible to encoding issues.Signed-off-by: mrshu mrshu@cisco.com