Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Client vs Environment #512

Closed
annevk opened this issue Oct 13, 2014 · 3 comments
Closed

Client vs Environment #512

annevk opened this issue Oct 13, 2014 · 3 comments

Comments

@annevk
Copy link
Member

annevk commented Oct 13, 2014

I will likely rename client to environment in Fetch as it represents an "environment settings object" (from HTML). I don't think it's exposed as a name anywhere yet, however it could be somewhat confusing if we have underlying concepts and exposed concepts with different names.

@KenjiBaheux
Copy link
Collaborator

Confirming that this is not exposed in blink (currently out of scope).

@jakearchibald
Copy link
Contributor

When I see environments I think development vs production.

@annevk
Copy link
Member Author

annevk commented Oct 20, 2014

So the observable places for this API-wise would be FetchEvent.client or Request.client (TBD which one) and ServiceWorkerGlobalScope.getClients(). (Assuming ServiceWorkerClient is split into BrowsingContext, Worker, and SharedWorker.)

Correct? I think I would be okay with client remaining the term to use here.

Pinging @Hixie as a heads up, though I believe he did not care much either way.

@annevk annevk closed this as completed Oct 23, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants