Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The prose for Clients.matchAll() distinguishes an omitted dictionary type argument #792

Closed
ehsan opened this issue Nov 30, 2015 · 2 comments

Comments

@ehsan
Copy link

ehsan commented Nov 30, 2015

According to the WebIDL spec, an optional argument with a dictionary type should always be considered to have a default value:

If the type of an argument is a dictionary type or a union type that has a dictionary type as one of its flattened member types, and that dictionary type and its ancestors have no required members, and the argument is either the final argument or is followed only by optional arguments, then the argument MUST be specified as optional. Such arguments are always considered to have a default value of an empty dictionary, unless otherwise specified.

Section 4.3.2 step 1.2 of Clients.matchAll() currently specifies a different behavior for when the argument is omitted, which probably needs to be changed accordingly:

If the optional argument options is omitted, then:

@ehsan
Copy link
Author

ehsan commented Nov 30, 2015

Implementor's feedback: In Gecko, our binding machinery doesn't even expose whether the dictionary type argument was passed in or not. I'm going to implement as if the step 1.2 of section 4.3.2 and everything under it was deleted.

@jungkees
Copy link
Collaborator

jungkees commented Dec 1, 2015

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants