-
-
Notifications
You must be signed in to change notification settings - Fork 128
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow Pretty format for develpment mode and deeper Slim configuration #30
Comments
The pretty proposal is reasonable. The second proposal however is not an option since Slim/Temple brings its own configuration framework independant of rails. |
I think it's a good idea, because we have a "slim-rails", and support rails configuration will be good for rails applications. |
+1 👍 |
I just ran into this. It would be nice to have application.rb/environments config so it would feel well integrated into rails.
It doesn't have to inherit rails configuration, it may have simple class which will proxy all configuration calls to slim engine. In pseudocode: class SlimRailsConfigProxy
def method_missing(method, args)
if Slim::Engine.options.respond_to?(method)
Slim::Engine.options.send(method, args)
else
raise ArgumentError, "Slim does not have option #{method}"
end
end
end @minad may you reconsider your decision? would you accept PR of such functionality? |
@Fedcomp sounds good. I'm the current maintainer of this gem, let's work on a new PR for this functionality. |
Okay thanks! i'll try to make a PR this or next weekend. |
@januszm sorry. Unfornately when i found time to work on it, i ran into incompatibility with rails 3, and left no time and willing to resolve it. And i'll probably stop. |
It would be nice to have this configurations bundled into the gem, won't you think?
And also have the config option inside rails application itself, so we could allow users to setup Slim completely without monkey-patching.
What you think about it?
The text was updated successfully, but these errors were encountered: