Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test/core/test_code_evaluation.rb may require 'ostruct' #888

Closed
boutil opened this issue Jul 16, 2022 · 1 comment
Closed

test/core/test_code_evaluation.rb may require 'ostruct' #888

boutil opened this issue Jul 16, 2022 · 1 comment

Comments

@boutil
Copy link

boutil commented Jul 16, 2022

Hi!

In Debian, the testsuite of your gem is run without the bundler/setup part. Everything is working fine, except one single error with 4.1.0:

  1) Error:
TestSlimCodeEvaluation#test_code_attribute_does_not_modify_argument:
NameError: uninitialized constant TestSlimCodeEvaluation::OpenStruct
    /<<PKGBUILDDIR>>/test/core/test_code_evaluation.rb:167:in `test_code_attribute_does_not_mod
ify_argument'

which is fixed by adding

require 'ostruct'

at the top of test/core/test_code_evaluation.rb.

Do you think it would be a sound change, in order to not rely on transitive require statements to ensure that OpenStruct is defined?

Thanks in advance

@k0kubun
Copy link
Member

k0kubun commented Oct 25, 2022

addressed in #893

@k0kubun k0kubun closed this as completed Oct 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants