Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GradientChat | Search bug with SlimeFun #4043

Closed
4 tasks done
SeptyIsHere opened this issue Dec 7, 2023 · 1 comment · Fixed by #4044
Closed
4 tasks done

GradientChat | Search bug with SlimeFun #4043

SeptyIsHere opened this issue Dec 7, 2023 · 1 comment · Fixed by #4044
Labels
🐞 Bug Report A bug that needs to be fixed. ✔ Resolved This Issue has been resolved.

Comments

@SeptyIsHere
Copy link

❗ Checklist

  • I am using the official english version of Slimefun and did not modify the jar.
  • I am using an up to date "DEV" (not "RC") version of Slimefun.
  • I am aware that issues related to Slimefun addons need to be reported on their bug trackers and not here.
  • I searched for similar open issues and could not find an existing bug report on this.

📍 Description

When I'm using /sf open_guide and search while using
I cannot search because it also gets the color of the message of the player. https://ibb.co/DL6HsL4

📑 Reproduction Steps

Just have gradientchat and have a gradient on yourself.

💡 Expected Behavior

I'll report here how you can fix it from the developer of the plugin
image
@ParametersAreNonnullByDefault public static void openSearch(PlayerProfile profile, String input, SlimefunGuideMode mode, boolean addToHistory) { SlimefunGuideImplementation guide = Slimefun.getRegistry().getSlimefunGuide(mode); guide.openSearch(profile, ChatColor.stripColor(input), addToHistory); }
This is (from what he told me) is needed to be fixed so you can search while you have a gradient.

📷 Screenshots / Videos

https://ibb.co/DL6HsL4

📜 Server Log

It does not matter

📂 /error-reports/ folder

It does not matter

💻 Server Software

Purpur

🎮 Minecraft Version

1.19.x

⭐ Slimefun version

image

🧭 Other plugins

GradientChat
https://www.spigotmc.org/resources/%E2%AD%90gradientplus%E2%AD%90gradient-chat-gradient-name%E2%AD%90best-gradient-plugin.111640/

@SeptyIsHere SeptyIsHere added 🎯 Needs testing This Issue needs to be tested by our team to see if it can be reproduced. 🐞 Bug Report A bug that needs to be fixed. labels Dec 7, 2023
@JustAHuman-xD
Copy link
Contributor

The dev was almost right but not quite how to fix it for all cases. I made the PR though.

@variananora variananora added ✔ Resolved This Issue has been resolved. and removed 🎯 Needs testing This Issue needs to be tested by our team to see if it can be reproduced. labels Dec 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐞 Bug Report A bug that needs to be fixed. ✔ Resolved This Issue has been resolved.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants