Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hazmat suit bug when just entering the server #4082

Closed
4 tasks done
LOURENT4462 opened this issue Jan 7, 2024 · 9 comments
Closed
4 tasks done

Hazmat suit bug when just entering the server #4082

LOURENT4462 opened this issue Jan 7, 2024 · 9 comments
Labels
🐞 Bug Report A bug that needs to be fixed.

Comments

@LOURENT4462
Copy link

LOURENT4462 commented Jan 7, 2024

❗ Checklist

  • I am using the official english version of Slimefun and did not modify the jar.
  • I am using an up to date "DEV" (not "RC") version of Slimefun.
  • I am aware that issues related to Slimefun addons need to be reported on their bug trackers and not here.
  • I searched for similar open issues and could not find an existing bug report on this.

📍 Description

when a player carries an item that has radiation (the player is already wearing a hazmat suit) then leaves the server and enters again, the player is safe from getting radiation effects, even though he is already wearing a hazmat suit

📑 Reproduction Steps

  1. Use a hazmat suit and bring Blistering ingot (has radiation)
  2. Log out of the server then log in again
  3. When re-entering the server, the player will not be detected if he is wearing a hazmat suit, so the player will suffer from radiation effects and die

💡 Expected Behavior

I hope players who use hazmat suits don't die from radiation from items when they first enter the server

📷 Screenshots / Videos

No response

📜 Server Log

No response

📂 /error-reports/ folder

No response

💻 Server Software

Paper

🎮 Minecraft Version

1.20.x

⭐ Slimefun version

Dev (Build 1123)

🧭 Other plugins

No response

@LOURENT4462 LOURENT4462 added 🎯 Needs testing This Issue needs to be tested by our team to see if it can be reproduced. 🐞 Bug Report A bug that needs to be fixed. labels Jan 7, 2024
@LOURENT4462
Copy link
Author

Additional information: after the player dies and respawns, the new hazmat suit functions to block radiation from items

@Boomer-1
Copy link

Boomer-1 commented Jan 7, 2024

can you please clarify what is happening? your statements are contrary. initially you've said the radiation effect doesn't harm the player then you said the opposite

@LOURENT4462
Copy link
Author

can you please clarify what is happening? your statements are contrary. initially you've said the radiation effect doesn't harm the player then you said the opposite

When a player joins the server, the player is exposed to radiation from the items he is carrying, even though the player is wearing a hazmat suit.

and after a player dies from radiation then respawns, the new hazmat suit kicks in, so the bug occurs when a new player enters the server

Sorry if my statement above is confusing...

@Boomer-1
Copy link

Boomer-1 commented Jan 7, 2024

in the config.yml file, what do you have your radiation grace period set to?

@LOURENT4462
Copy link
Author

in the config.yml file, what do you have your radiation grace period set to?

  enable-radiation: true
  radiation-update-interval: 1
  radiation-grace-period: 15

@J3fftw1
Copy link
Member

J3fftw1 commented Jan 7, 2024

We should ignore the grace periods on start up/onjoin and fire this directly so this will never be an issue

@WalshyDev
Copy link
Member

I'm unable to repro, I join and have protection without issue.

Debug logs:

[14:22:58 INFO]: [Slimefun] onJoin: PlayerProfile.get
[14:22:58 INFO]: [Slimefun] Hashed armor: [HashedArmorpiece {hash=0,item=null}, HashedArmorpiece {hash=0,item=null}, HashedArmorpiece {hash=0,item=null}, HashedArmorpiece {hash=0,item=null}]
[14:22:58 INFO]: [Slimefun] [STDOUT] Armor piece sf item: HazmatArmorPiece - 'RUBBER_BOOTS' (Slimefun v4.9-UNOFFICIAL)
[14:22:58 WARN]: Nag author(s): '[The Slimefun 4 Community]' of 'Slimefun v4.9-UNOFFICIAL' about their usage of System.out/err.print. Please use your plugin's logger instead (JavaPlugin#getLogger).
[14:22:58 INFO]: [Slimefun] Updated hashed armor pieces
[14:22:58 INFO]: [Slimefun] [STDOUT] Armor piece sf item: HazmatArmorPiece - 'HAZMAT_LEGGINGS' (Slimefun v4.9-UNOFFICIAL)
[14:22:58 INFO]: [Slimefun] Updated hashed armor pieces
[14:22:58 INFO]: [Slimefun] [STDOUT] Armor piece sf item: HazmatArmorPiece - 'HAZMAT_CHESTPLATE' (Slimefun v4.9-UNOFFICIAL)
[14:22:58 INFO]: [Slimefun] Updated hashed armor pieces
[14:22:58 INFO]: [Slimefun] [STDOUT] Armor piece sf item: HazmatArmorPiece - 'SCUBA_HELMET' (Slimefun v4.9-UNOFFICIAL)
[14:22:58 INFO]: [Slimefun] Updated hashed armor pieces
[14:22:58 INFO]: [Slimefun] Player tick, protection against raditation: true
[14:22:59 INFO]: [Slimefun] Player tick, protection against raditation: true
[14:23:00 INFO]: [Slimefun] Player tick, protection against raditation: true
[14:23:01 INFO]: [Slimefun] Player tick, protection against raditation: true
[14:23:02 INFO]: [Slimefun] Player tick, protection against raditation: true
[14:23:03 INFO]: [Slimefun] Player tick, protection against raditation: true

@LOURENT4462
Copy link
Author

I'm unable to repro, I join and have protection without issue.

Debug logs:

[14:22:58 INFO]: [Slimefun] onJoin: PlayerProfile.get
[14:22:58 INFO]: [Slimefun] Hashed armor: [HashedArmorpiece {hash=0,item=null}, HashedArmorpiece {hash=0,item=null}, HashedArmorpiece {hash=0,item=null}, HashedArmorpiece {hash=0,item=null}]
[14:22:58 INFO]: [Slimefun] [STDOUT] Armor piece sf item: HazmatArmorPiece - 'RUBBER_BOOTS' (Slimefun v4.9-UNOFFICIAL)
[14:22:58 WARN]: Nag author(s): '[The Slimefun 4 Community]' of 'Slimefun v4.9-UNOFFICIAL' about their usage of System.out/err.print. Please use your plugin's logger instead (JavaPlugin#getLogger).
[14:22:58 INFO]: [Slimefun] Updated hashed armor pieces
[14:22:58 INFO]: [Slimefun] [STDOUT] Armor piece sf item: HazmatArmorPiece - 'HAZMAT_LEGGINGS' (Slimefun v4.9-UNOFFICIAL)
[14:22:58 INFO]: [Slimefun] Updated hashed armor pieces
[14:22:58 INFO]: [Slimefun] [STDOUT] Armor piece sf item: HazmatArmorPiece - 'HAZMAT_CHESTPLATE' (Slimefun v4.9-UNOFFICIAL)
[14:22:58 INFO]: [Slimefun] Updated hashed armor pieces
[14:22:58 INFO]: [Slimefun] [STDOUT] Armor piece sf item: HazmatArmorPiece - 'SCUBA_HELMET' (Slimefun v4.9-UNOFFICIAL)
[14:22:58 INFO]: [Slimefun] Updated hashed armor pieces
[14:22:58 INFO]: [Slimefun] Player tick, protection against raditation: true
[14:22:59 INFO]: [Slimefun] Player tick, protection against raditation: true
[14:23:00 INFO]: [Slimefun] Player tick, protection against raditation: true
[14:23:01 INFO]: [Slimefun] Player tick, protection against raditation: true
[14:23:02 INFO]: [Slimefun] Player tick, protection against raditation: true
[14:23:03 INFO]: [Slimefun] Player tick, protection against raditation: true

sorry... I just tried it and the hazmat suit is working again... maybe when the bug occurred there were other factors that caused it,

thank you for your time 👍

@WalshyDev
Copy link
Member

No worries, if you can figure out what happened and it is an issue let us know :)

@WalshyDev WalshyDev removed the 🎯 Needs testing This Issue needs to be tested by our team to see if it can be reproduced. label Jan 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐞 Bug Report A bug that needs to be fixed.
Projects
None yet
Development

No branches or pull requests

4 participants