Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Overlay] Rotate logfile instead of erasing every time #189

Closed
TheButlah opened this issue Feb 19, 2023 · 0 comments · Fixed by #191
Closed

[Overlay] Rotate logfile instead of erasing every time #189

TheButlah opened this issue Feb 19, 2023 · 0 comments · Fixed by #191
Labels
Area: Overlay Relating to the SteamVR Overlay subproject Difficulty: Good for Newcomers Good issue for newcomers to tackle Priority: Low Not as important. Type: Enhancement A new feature or improvement

Comments

@TheButlah
Copy link
Collaborator

TheButlah commented Feb 19, 2023

#187 Introduced a logfile. It will always erase the last log at program start. Since past errors are helpful when debugging users' errors, we should instead rotate the logfile. This means that there is some maximum file size (or number of lines) that we permit, and once we hit that maximum size, we truncate old logs until we are back at the maximum size.

@TheButlah TheButlah added Difficulty: Good for Newcomers Good issue for newcomers to tackle Area: Overlay Relating to the SteamVR Overlay subproject Type: Enhancement A new feature or improvement Priority: Low Not as important. labels Feb 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Overlay Relating to the SteamVR Overlay subproject Difficulty: Good for Newcomers Good issue for newcomers to tackle Priority: Low Not as important. Type: Enhancement A new feature or improvement
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant