Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Firmware] Get CI to also check firmware #29

Closed
TheButlah opened this issue Aug 22, 2022 · 3 comments
Closed

[Firmware] Get CI to also check firmware #29

TheButlah opened this issue Aug 22, 2022 · 3 comments
Labels
Area: Firmware Relating to the firmware subprojct Difficulty: Good for Newcomers Good issue for newcomers to tackle

Comments

@TheButlah
Copy link
Collaborator

I had to remove the firmware from the cargo workspace, because it only compiles on RISC-V currently, and has its own cargo.toml. I wasn't sure how to do this in a better way, so for now I removed it from the cargo workspace.

I saw that rust-lang/cargo#5220 exists but seems to have no movement.

One solution is for me to have the main.rs have a cfg(platform) feature gate. And maybe I could feature gate the dependencies and then activate that feature when on the appropriate architecture?

@TheButlah TheButlah added Difficulty: Good for Newcomers Good issue for newcomers to tackle Area: Firmware Relating to the firmware subprojct labels Aug 22, 2022
@TheButlah TheButlah changed the title Get CI to also check firmware [Firmware] Get CI to also check firmware Nov 27, 2022
@ImUrX
Copy link
Member

ImUrX commented Dec 2, 2022

more simple: make an action for firmware, it will simplify things later when we do want to cargo build for different archs

@TheButlah
Copy link
Collaborator Author

TheButlah commented Dec 2, 2022

more simple: make an action for firmware

Agreed - this is the right approach. We don't need one single workspace, any code that can't also compile to host architectures can go in firmware workspace.

Long term, maybe we can get the firmware to compile via linux-embedded-linux for the purposes of testing, but even then, thats platform specific, it won't work on mac or windows.

@TheButlah
Copy link
Collaborator Author

Closed by #104

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Firmware Relating to the firmware subprojct Difficulty: Good for Newcomers Good issue for newcomers to tackle
Projects
None yet
Development

No branches or pull requests

2 participants