Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

judiTopmute ERROR: n not defined #165

Closed
kerim371 opened this issue Dec 29, 2022 · 1 comment · Fixed by #166
Closed

judiTopmute ERROR: n not defined #165

kerim371 opened this issue Dec 29, 2022 · 1 comment · Fixed by #166

Comments

@kerim371
Copy link
Contributor

Hi,

It seems n is missing here. It should probably be:

judiTopmute(n::NTuple{N, Integer}, wb::Array{T, Nw}, taperwidth::Integer) where {T, N, Nw} = TopMute(prod(n), wb, taperwidth)

# instead of:
# judiTopmute(::NTuple{N, Integer}, wb::Array{T, Nw}, taperwidth::Integer) where {T, N, Nw} = TopMute(prod(n), wb, taperwidth)
@mloubout
Copy link
Member

It is indeed missing for that case looks like only the integer case is tested. Should be easy to fix

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants