Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

File destination - have a skip option for same file name instead of replace/delete #282

Closed
dduong1603 opened this issue Apr 29, 2024 · 8 comments
Labels
enhancement New feature or request

Comments

@dduong1603
Copy link

dduong1603 commented Apr 29, 2024

Right now Sling deletes the file and replace it with a new file. This changes the update time of the file and potentially impacts downstream workflow. Can we get a skip/ignore-existing option instead?

@dduong1603 dduong1603 added the enhancement New feature or request label Apr 29, 2024
@flarco
Copy link
Collaborator

flarco commented Apr 29, 2024

Interesting. So, basically, if the destination file/object exists, do nothing?

@flarco
Copy link
Collaborator

flarco commented Apr 29, 2024

In your situation, is the stream incremental? is the source a database or file?

@dduong1603
Copy link
Author

dduong1603 commented Apr 29, 2024

The stream is not incremental, and the source is a file (trying to do a file to file transfer), and we want to write that same file to multiple destinations, and if something fails midway, we want to retry the process but skip the destinations that already have that file. We could probably hack together something in our process to ignore the CLI call for those particular destinations, but thought it would be nice to have a flag in the CLI call or as part of the tgt-options 😄

@dduong1603
Copy link
Author

dduong1603 commented Apr 29, 2024

I guess this also applies to multiple streams within a single destination/replication, and we want to skip the file/stream that has the same destination name since they are all within the same CLI call

@flarco
Copy link
Collaborator

flarco commented Apr 30, 2024

Cool, will add a ignore_existing key in target-options.

@dduong1603
Copy link
Author

any update on this @flarco ?

@flarco
Copy link
Collaborator

flarco commented May 15, 2024

Should be completed this week for upcoming release #289 (likely this weekend).

@flarco
Copy link
Collaborator

flarco commented May 15, 2024

Done (cc6b5d1). Feel free to compile binary and test.

@flarco flarco closed this as completed May 15, 2024
@flarco flarco mentioned this issue May 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants