Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

/ and 0 #43

Closed
puredanger opened this issue Oct 24, 2018 · 1 comment
Closed

/ and 0 #43

puredanger opened this issue Oct 24, 2018 · 1 comment

Comments

@puredanger
Copy link

It is wrong imo to exclude 0 in the divisor. The function accepts any number and that's the truth of it. Don't try to hide a case that happens to throw.
@mfikes
Copy link
Collaborator

mfikes commented Oct 24, 2018

Yeah, there could be perfectly valid code that intentionally catches divide by zero and handles it as an exceptional case—a spec shouldn’t prevent that.

slipset added a commit that referenced this issue Oct 26, 2018
@slipset
Revert "[Fix #43] Specing against 0 divisor doesn't make sense"
6f8dc66 
This reverts commit 0edc4ef.
slipset added a commit that referenced this issue Oct 26, 2018
@slipset
[Fix #43] Division is for all numbers
18b5cb3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@puredanger @mfikes