Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement forceful termination of launched CLI after a timeout in Java ProcessUtils. #240

Closed
st opened this issue Feb 27, 2015 · 1 comment

Comments

@st
Copy link
Contributor

st commented Feb 27, 2015

Implement forceful termination of launched CLI after a timeout in Java ProcessUtils (connector).
If CLI doesn't respect provided timeout, (and goes zombie), Java side should kill this process.

@konstan
Copy link
Member

konstan commented Mar 23, 2015

This is where change should happen https://github.com/slipstream/SlipStreamServer/blob/master/jar-connector/src/main/java/com/sixsq/slipstream/util/ProcessUtils.java#L72

The problem here is to obtain the timeout the CLI was started with. Might need to update the signature of some of execGetOutput*() methods to explicitly require the timeout. If the CLI didn't return after timeout + (say) 2 sec - kill it with a system call and report back the collected std/err outputs.

@mebster mebster modified the milestones: v2.7.0, v2.6.0 Mar 31, 2015
@mebster mebster modified the milestones: v2.8, v2.7.0 Apr 14, 2015
@mebster mebster assigned konstan and unassigned st Apr 15, 2015
@loomis loomis modified the milestones: v2.9, v2.8 May 1, 2015
@loomis loomis removed this from the v2.9 milestone May 19, 2015
@st st added the ★★★ label Jul 25, 2016
@st st removed the label Jul 25, 2016
@loomis loomis closed this as completed Jul 24, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants