Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Line 5 #1

Open
bellane opened this issue Apr 26, 2019 · 3 comments
Open

Line 5 #1

bellane opened this issue Apr 26, 2019 · 3 comments

Comments

@bellane
Copy link

bellane commented Apr 26, 2019

Do you mean line 6?

https://i.gyazo.com/a9c7065802ec4832d4f8c6d55c8329ff.png

Kinda confused about this as deleting 5 and replacing it breaks it. Also replacing 6 still leaves it broken.

@slizzarn
Copy link
Owner

Just copy mine,

	let MenuTpl =
		'<div id="menu_{{_namespace}}_{{_name}}" class="dialog {{#isBig}}big{{/isBig}}">' +
			'{{#isDefault}}<input type="text" name="value" placeholder="{{title}}" id="inputText"/>{{/isDefault}}' +
				'{{#isBig}}<textarea name="value"/>{{/isBig}}' +
				'<button type="button" name="submit">Sumbit</button>' +
				'<button type="button" name="cancel">Cancel</button>'
			'</div>' +
		'</div>'
	;

@codygulley
Copy link

For some reason, replacing this with yours makes the menu break.

If I replace the file with the code below it works, but when I replace it with the code you posted above it breaks.

let MenuTpl =
   	'<div id="menu_{{_namespace}}_{{_name}}" class="menu{{#align}} align-{{align}}{{/align}}">' +
   		'<div class="head"><span>{{{title}}}</span></div>' +
   			'<div class="menu-items">' + 
   				'{{#elements}}' +
   					'<div class="menu-item {{#selected}}selected{{/selected}}">' +
   						'{{{label}}}{{#isSlider}} : &lt;{{{sliderLabel}}}&gt;{{/isSlider}}' +
   					'</div>' +
   				'{{/elements}}' +
   			'</div>'+
   		'</div>' +
   	'</div>'
   ;

You should update your README as the instructions to replace the current lines in app.js cause the menu to break and be unstyled. See screenshot below.

esx_menu_default_styling_bug

@iSentrie
Copy link

Works fine for me. Very nice style.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants