Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Manual module loading #4

Closed
schickling opened this issue Jul 25, 2014 · 2 comments
Closed

Manual module loading #4

schickling opened this issue Jul 25, 2014 · 2 comments

Comments

@schickling
Copy link
Contributor

The module shouldn't be loaded per default. You should need to load it via

angular.module('app', ['angularMapbox']);
@sllvn
Copy link
Owner

sllvn commented Jul 27, 2014

This was an attempt to minimize the technical overhead to use the directives. Intent was user includes just the script and Angular bootstrapping is handled automatically (similar to variancecharts.com); or not handled it all, if bootstrapping has already been handled by the app through ng-app or manual bootstrapping. There appear to be bugs with that process.

I'm in a bit of a work crunch right now and likely won't be able to investigate for a couple weeks, but if you have any ideas on how to hit both use cases, I'd love to hear your ideas. Or if you think I should scrap supporting non-technical users entirely (and force some level of Angular knowledge), I'm all ears.

http://www.2ality.com/2014/07/angularjs-vs-polymer.html (point 1) has me leaning toward scrapping support of complete non-technical users altogether, which would eliminate the need for bootstrapping/module-loading.

@sllvn
Copy link
Owner

sllvn commented Dec 28, 2014

Removed the dumbed down, non-technical distribution of this lib and am going to require some Angular experience to use the directives, esp. since Mapbox.js now requires the user to set an API access token at some point.

@sllvn sllvn closed this as completed Dec 28, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants