Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Tooltip breaks in specific cases, causes infinite re-renders and crashes #49

Closed
essensx opened this issue Mar 31, 2020 · 5 comments
Labels

Comments

@essensx
Copy link

essensx commented Mar 31, 2020

Not completely sure what is happening here, seems since the lib can't properly position the tooltip, it tries to reposition it infinitely.

Sample: https://codesandbox.io/s/awesome-ellis-yyjyf

Steps To Reproduce

Result

App crashes, React throws an exception of setState depth reached.

@ranihorev
Copy link
Contributor

ranihorev commented Apr 3, 2020

Here is a fix - #50

@essensx
Copy link
Author

essensx commented May 5, 2020

Any updates?

@slmgc
Copy link
Owner

slmgc commented Jul 17, 2020

@essensx whoah, looks like I totally missed that issue, sorry about that.
@ranihorev thanks a lot for the fix, I started the review, will try to check everything this weekend.

@slmgc slmgc added the bug label Jul 17, 2020
@davidesigner
Copy link

Hi @slmgc, could you merge the fix of @ranihorev #50 please? Thank you!

@slmgc
Copy link
Owner

slmgc commented Apr 2, 2021

Hi everyone, sorry for not responding on time :/
Merged and released a new version with the fix, thanks a lot @essensx and @ranihorev

@slmgc slmgc closed this as completed Apr 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants