Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problems with IElementSizing in Monotouch.Dialog included into MvvmCross #182

Closed
asednev opened this issue Mar 6, 2013 · 12 comments
Closed
Labels
s/needs-investigation Needs investigation by the MvvmCross team

Comments

@asednev
Copy link
Contributor

asednev commented Mar 6, 2013

All elements are always sized the same and IElementSizing is ignored. Even MessageElement that comes as a part of MT.D isn't sized properly.

@slodge
Copy link
Contributor

slodge commented Mar 6, 2013

I know people have done custom sized elements:
#142

If you've got a problem, then you're going to need to supply way more detail than 1 line - a full reproduction test case would help.

@alexshikov
Copy link
Contributor

Have you tried set Root.UnevenRows=true?

@asednev
Copy link
Contributor Author

asednev commented Mar 6, 2013

Yes, I have UnevenRows set to true. I'll try to build a stand-alone reproduction. For now, I can only show a screen shot of a dialog with MessageElement and MultilineEntryElements added. You can clearly see that the height of both rows is incorrect. Since other people managed to build controls of variable height, I would appreciate any clues. I may well miss something.

iOS Simulator Screen shot Mar 6 2013 11 22 30 AM

@slodge
Copy link
Contributor

slodge commented Mar 11, 2013

Is there any more on this? Simple code to repro? Or have you already solved whatever it was?

@asednev
Copy link
Contributor Author

asednev commented Mar 12, 2013

Yes, I finally have a very simple project that reproduces the issue: https://github.com/asednev/MvvmCrossIssue

@alexshikov
Copy link
Contributor

Hi, asednev.

Try to replace this code in MyViewController.cs (starts from line 24)

            Root = new RootElement("Test")
            {
                sec
            };
            Root.UnevenRows = true;

with this

            var root = new RootElement("Test")
            {
                sec
            };
            root.UnevenRows = true;
            Root = root;

@asednev
Copy link
Contributor Author

asednev commented Mar 12, 2013

This fixed it. Thank you SeeD-Seifer.

@asednev asednev closed this as completed Mar 12, 2013
@slodge
Copy link
Contributor

slodge commented Mar 12, 2013

Thanks guys

Looking through the Dialog code this seems to come from the MT.D version I forked.

It looks like the sizing info is only used from within ReloadData() so maybe this is down to CrossUI.Touch never calling that method.

Will have a closer look later.

Thanks all - for the issue, the sample and the workaround/fix.

@asednev
Copy link
Contributor Author

asednev commented Mar 12, 2013

Stuart, when I did my research on this issue, I came across several bug reports about sizing info not working in MT.D. It might well be possible that it was fixed after you forked it.

@slodge
Copy link
Contributor

slodge commented Mar 15, 2013

Going to reopen this one up.

would be nice to be able to reload the cell later in it's life

need to find some way to call

        reloadRowsAtIndexPaths

at some point (maybe on UI change)

@slodge slodge reopened this Mar 15, 2013
@slodge
Copy link
Contributor

slodge commented Mar 15, 2013

For a sample of the current problem, consider the current Details page on CustomerManagement (normal - not AutoViews)

martijn00 pushed a commit to martijn00/MvvmCross that referenced this issue Dec 8, 2016
Removed Cirrious nuspecs (not needed anymore).
@kjeremy
Copy link
Contributor

kjeremy commented Dec 12, 2016

CrossUI/Dialog has been removed as of 41f1915

@kjeremy kjeremy closed this as completed Dec 12, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
s/needs-investigation Needs investigation by the MvvmCross team
Development

No branches or pull requests

4 participants