Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review the list of emit_x functions in Serializer. #28

Closed
dpc opened this issue Aug 3, 2016 · 1 comment
Closed

Review the list of emit_x functions in Serializer. #28

dpc opened this issue Aug 3, 2016 · 1 comment
Labels
C-enhancement Category: An issue proposing an enhancement or a PR with one.
Milestone

Comments

@dpc
Copy link
Collaborator

dpc commented Aug 3, 2016

While not tragic, every time this list changes, API breaks for serializer adapters (slog-serde).

Also, while at it, review the list of types implementing Serializable. Adding these is backward-compatible, but it's better to check now.

@dpc dpc added this to the 1.0 milestone Aug 3, 2016
@dpc dpc added the C-enhancement Category: An issue proposing an enhancement or a PR with one. label Aug 3, 2016
@dpc
Copy link
Collaborator Author

dpc commented Aug 17, 2016

LGTM. Some notes:

  • there is no sequences, as that would complicate everything; plus it's not a full serializer so no need for it, I believe
  • there is no distinct emit_some as that would complicate everything; serialized value just knows if something was none or something, and will call the right method.

@dpc dpc closed this as completed Aug 17, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-enhancement Category: An issue proposing an enhancement or a PR with one.
Projects
None yet
Development

No branches or pull requests

1 participant