DateTime::createFromFormat with now throws an error: Call to a member function setTime() on bool

[faille76]

Hello,

I'm having an issue when I want to instantiate a DateTime using the createFromFormat method if I specify the format as now and the datetime as a date with no time (ex: 2022-08-04).

Example:

ClockMock::freeze(new \DateTimeImmutable('1986-06-05 12:13:14'));
$dateTime = \DateTime::createFromFormat('\n\o\w', '2022-01-01');

Output:

Error: Call to a member function setTime() on bool

Expected:
The createFromFormat method must return false if the date doesn't match the format.

Solution:
Do not try to set the time when \DateTime::createFromFormat returns false.
In src/ClockMock.php:
Replace

private static function mock_date_create_from_format(): callable
{
// ...
if ($parsedDate['hour'] === false) {
// ..
}

With:

private static function mock_date_create_from_format(): callable
{
// ...
if ($parsedDate['hour'] === false && $dateTimeObject !== false) {
// ...
}

~ faille76